rouggy/OpsLog
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 25 Wiki Activity

fix: correcting proper bit to see when Steppir is moving

Browse Source
This commit is contained in:
rouggy
2026-07-16 00:48:10 +02:00
parent 9d7091b1b8
commit b83a4f4455
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/steppir/steppir.go
+7 -3
View File
@@ -253,10 +253,14 @@ func parseStatus(b []byte) (*Status, error) {
freqHz := int(int32(binary.BigEndian.Uint32(b[2:6]))) * 10 freqHz := int(int32(binary.BigEndian.Uint32(b[2:6]))) * 10
active := b[6] active := b[6]
dir := decodeDir(b[7]) dir := decodeDir(b[7])
// active==0xFF means "command just received" (not motion); the 0x01 bit is // active-motors byte: one bit per element that is currently moving.
// documented as always set. Treat anything else non-zero as motors busy. // 0x04 driver · 0x08 DIR1 · 0x10 reflector · 0x20 DIR2 (mask 0x3C)
// Bit 0 (0x01) is documented as always set — not a motor. 0xFF means the
// controller just received a command, not motion. So "moving" is precisely
// "any real motor bit set", ignoring the always-on bit and the ack value.
const motorBits = 0x3C
moving := 0 moving := 0
if active != 0xFF && (active & ^byte(0x01)) != 0 { if active != 0xFF && active&motorBits != 0 {
moving = 1 moving = 1
} }
return &Status{Frequency: freqHz / 1000, Direction: dir, MotorsMoving: moving}, nil return &Status{Frequency: freqHz / 1000, Direction: dir, MotorsMoving: moving}, nil