fix(stats): confirmed outranks worked in the band/mode matrix
Reported by VK4DX with the case that names itself: YB confirmed on 20m digital, painted blue, because one unconfirmed YB station had also been worked on that slot. The ladder ran call_c > call_w > dxcc_c > dxcc_w, so a callsign worked and not confirmed beat an entity CONFIRMED on the same band and mode. The grid answers 'what do I still need here', and a confirmed entity needs nothing whoever was worked afterwards — so the order is now call_c > dxcc_c > call_w > dxcc_w. Two things made it easy to get wrong, and both are fixed rather than merely corrected. The code was a run of assignments where the later test silently overwrote the earlier, so 'call worked' erased 'entity confirmed'; it now takes the maximum. And the rule lived inside a scan loop where nothing could reach it, so it is lifted into bandStatusCode with a table test — including this exact case, and one that fails if anybody reorders the constants.
This commit is contained in:
+4
-2
@@ -3,10 +3,12 @@
|
||||
"version": "0.26.17",
|
||||
"date": "",
|
||||
"en": [
|
||||
"Awards, RDA district comparison: each disagreement can now be settled on its own row. Click the district you keep — the log's or the database's — and apply. The choice becomes the contact's award reference, so it is what counts, while both sources keep saying what they said."
|
||||
"Awards, RDA district comparison: each disagreement can now be settled on its own row. Click the district you keep — the log's or the database's — and apply. The choice becomes the contact's award reference, so it is what counts, while both sources keep saying what they said.",
|
||||
"The band/mode matrix: a confirmed slot now shows as confirmed. A callsign worked and not confirmed was outranking an entity CONFIRMED on the same band and mode, so a slot that needs nothing was painted as if it still did."
|
||||
],
|
||||
"fr": [
|
||||
"Diplômes, comparaison des districts RDA : chaque divergence se règle désormais sur sa propre ligne. Cliquer le district qu'on garde — celui du log ou celui de la base — puis appliquer. Le choix devient la référence de diplôme du contact, donc c'est lui qui compte, tandis que les deux sources continuent de dire ce qu'elles disaient."
|
||||
"Diplômes, comparaison des districts RDA : chaque divergence se règle désormais sur sa propre ligne. Cliquer le district qu'on garde — celui du log ou celui de la base — puis appliquer. Le choix devient la référence de diplôme du contact, donc c'est lui qui compte, tandis que les deux sources continuent de dire ce qu'elles disaient.",
|
||||
"Matrice bandes/modes : une case confirmée s'affiche enfin comme confirmée. Un indicatif travaillé et non confirmé l'emportait sur une entité CONFIRMÉE sur la même bande et le même mode, si bien qu'une case qui ne demandait plus rien était peinte comme s'il manquait encore quelque chose."
|
||||
]
|
||||
},
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user