rouggyandClaude Opus 5
8b1dff581b
Measured rather than guessed: the whole repository was cross-compiled for
linux/amd64 and the gaps closed one by one. There were fewer than expected.
Flex and TCI were never Windows-specific — they carried //go:build windows by
inheritance and import nothing but net and gorilla/websocket. Untagged, no code
change. The two backends a Linux operator is most likely to own were already
portable.
Audio was 560 lines, not 2287: only devices.go and engine.go touch WASAPI, while
manager.go, recorder.go, wav.go and mp3.go were pure Go wearing the tag by
association. The whole platform surface is seven functions, now implemented a
second time on PulseAudio through github.com/jfreymuth/pulse — pure Go over the
server socket, so the no-cgo rule survives, and PipeWire answers the same
protocol. The fixed 16 kHz mono format and the server-side resampling mirror
what AUTOCONVERTPCM does on Windows, for the same reason.
OmniRig is the only real loss, and its backend still EXISTS off Windows rather
than being compiled out of app.go: a settings database is portable, so an
operator moving a profile across keeps "omnirig" saved and must be told to pick
a native backend instead of meeting a nil one.
The parts where Linux is not Windows, and where a compile-only stub would have
been a silent bug:
- data dir: still beside the binary, but ~/.local/share/OpsLog/data when that
folder belongs to the system — decided by trying the write, because /opt and
/usr/local are writable on some stations and not others.
- single instance: an flock, not a pid file. The kernel drops it however the
process dies, so a crash leaves nothing to delete by hand. This is the guard
that stops two instances fighting over the rig frequency.
- update: simpler here. Unix renames over a running binary, so the deferred
swap the Windows path needs a detached helper for is unreachable.
- tasklist/taskkill become /proc and SIGTERM; the boot log moves out of /tmp,
which is wiped exactly when the evidence is wanted.
- serial ports sorted naturally: /dev/ttyUSB10 was landing between USB1 and
USB2, the same trap COM10 fell into.
release.ps1 now cross-builds and vets for linux before it builds the exe, and
refuses the release if that fails — a port rots one unguarded x/sys/windows call
at a time.
Nothing has been executed on Linux yet: Wails needs webkit2gtk and cgo there, so
the binary must be built on Linux. scripts/linux-setup.sh checks the machine and
does it; BUILDING-LINUX.md is the manual version.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
57 lines
2.3 KiB
Go
57 lines
2.3 KiB
Go
package main
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// The exact list an operator's machine produced: COM1 and COM3 each claimed by
|
|
// two devices in the Windows port map, and no order to speak of. The dropdown
|
|
// showed every duplicate, and rendered its own value as "COM3COM3" because two
|
|
// entries with the same value both counted as selected.
|
|
func TestTidySerialPortsDeduplicatesAndOrders(t *testing.T) {
|
|
got := tidySerialPorts([]string{"COM1", "COM1", "COM3", "COM8", "COM9", "COM4", "COM3"})
|
|
want := []string{"COM1", "COM3", "COM4", "COM8", "COM9"}
|
|
if strings.Join(got, ",") != strings.Join(want, ",") {
|
|
t.Errorf("got %v, want %v", got, want)
|
|
}
|
|
}
|
|
|
|
// COM10 after COM9, not between COM1 and COM2 — lexical order is how a port
|
|
// gets overlooked on a machine with a dozen of them.
|
|
func TestTidySerialPortsSortsNaturally(t *testing.T) {
|
|
got := tidySerialPorts([]string{"COM10", "COM2", "COM1", "COM20", "COM3"})
|
|
want := []string{"COM1", "COM2", "COM3", "COM10", "COM20"}
|
|
if strings.Join(got, ",") != strings.Join(want, ",") {
|
|
t.Errorf("got %v, want %v", got, want)
|
|
}
|
|
}
|
|
|
|
// Not every port is a COMn: a device path or a Unix name must survive, after
|
|
// the numbered ones, in its own order.
|
|
func TestTidySerialPortsKeepsOtherNames(t *testing.T) {
|
|
got := tidySerialPorts([]string{"/dev/ttyUSB1", "COM3", "/dev/ttyUSB0", "COM1", "", " "})
|
|
want := []string{"COM1", "COM3", "/dev/ttyUSB0", "/dev/ttyUSB1"}
|
|
if strings.Join(got, ",") != strings.Join(want, ",") {
|
|
t.Errorf("got %v, want %v", got, want)
|
|
}
|
|
}
|
|
|
|
// Case is not identity on Windows: "com3" and "COM3" are one port, and letting
|
|
// both through would put the same duplicate back in the list.
|
|
func TestTidySerialPortsIgnoresCase(t *testing.T) {
|
|
if got := tidySerialPorts([]string{"COM3", "com3"}); len(got) != 1 || got[0] != "COM3" {
|
|
t.Errorf("got %v, want [COM3]", got)
|
|
}
|
|
}
|
|
|
|
// On Linux the ports are paths, and the same trap is waiting there:
|
|
// /dev/ttyUSB10 sorted lexically lands between USB1 and USB2.
|
|
func TestTidySerialPortsSortsUnixNamesNaturally(t *testing.T) {
|
|
got := tidySerialPorts([]string{"/dev/ttyUSB10", "/dev/ttyUSB2", "/dev/ttyACM0", "/dev/ttyUSB1"})
|
|
want := []string{"/dev/ttyACM0", "/dev/ttyUSB1", "/dev/ttyUSB2", "/dev/ttyUSB10"}
|
|
if strings.Join(got, ",") != strings.Join(want, ",") {
|
|
t.Errorf("got %v, want %v", got, want)
|
|
}
|
|
}
|